✨ [Effect 29-30, 34] 継続ダメージ・回復エフェクトの実装 #841
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiiro2gou
changed the title
haiiro2gou
changed the title
Lapis-LJA
reviewed
Mar 6, 2025
Asset/data/asset/functions/effect/0029.poison/register.mcfunction
Outdated
Show resolved
Hide resolved
Lapis-LJA
reviewed
Mar 8, 2025
Lapis-LJA
requested changes
Mar 8, 2025
| # ID (int) | ||
| data modify storage asset:effect ID set value 266 | ||
| # 名前 (TextComponentString) | ||
| data modify storage asset:effect Name set value "大地の恵み" |
There was a problem hiding this comment.
TextComponentじゃなさそう
それと、防具名と一致してないのが気になる
Comment on lines
+13
to
+19
|
|
||
| # $Healの方が大きいならそのまま | ||
| # LatestHealの方が大きいなら、スコアのデータをフィールドへ代入 | ||
| execute if score $Heal Temporary < @s 301.LatestHeal store result storage asset:context this.Heal float 0.1 run scoreboard players get @s 301.LatestHeal | ||
| execute if score $Heal Temporary < @s 301.LatestHeal store result storage asset:context this.UserID float 0.1 run scoreboard players get @s 301.LatestUserID | ||
|
|
||
| # リセット |
There was a problem hiding this comment.
自分が書いたコードなのでアレなんだが、re-given前に付与されてたStackの方が大きいなら強制置き換えがあるべきかも
| data modify storage api: Argument.BypassArmorToughness set value true | ||
| data modify storage api: Argument.BypassEnchantments set value true | ||
| data modify storage api: Argument.BypassDifficulty set value true | ||
| data modify storage api: Argument.ActivateTrigger set value false |
There was a problem hiding this comment.
1.ActivateTriggerじゃなさそう
2.それにこれになんでトリガー呼び出しがないの？
3.デスログがないと死んだ際にバグりそう
4. #1030 とめちゃくちゃconflictしそう
| data modify storage api: Argument.FixedHeal set value true | ||
| function api:heal/modifier | ||
| data modify storage api: Argument.FixedHeal set value false | ||
| data modify storage api: Argument.ActivateTrigger set value false |
There was a problem hiding this comment.
Suggested change
| data modify storage api: Argument.ActivateTrigger set value false | |
| data modify storage api: Argument.ApplyTrigger set value false |
| data modify storage api: Argument.BypassArmorToughness set value true | ||
| data modify storage api: Argument.BypassEnchantments set value true | ||
| data modify storage api: Argument.BypassDifficulty set value true | ||
| data modify storage api: Argument.ActivateTrigger set value false |
There was a problem hiding this comment.
Suggested change
| data modify storage api: Argument.ActivateTrigger set value false | |
| data modify storage api: Argument.ApplyTrigger set value false |
| @@ -13,6 +13,7 @@ | |||
| data modify storage api: Argument.Damage set value 25.0f | |||
| data modify storage api: Argument.AttackType set value "Physical" | |||
| execute as @a if score @s UserID = $AppliedFrom Temporary run function api:damage/modifier | |||
| data modify storage api: Argument.ActivateTrigger set value false | |||
There was a problem hiding this comment.
Suggested change
| data modify storage api: Argument.ActivateTrigger set value false | |
| data modify storage api: Argument.ApplyTrigger set value false |
| @@ -7,5 +7,6 @@ | |||
| # 回復 | |||
| data modify storage api: Argument.Heal set value 1.5f | |||
| function api:heal/modifier | |||
| data modify storage api: Argument.ActivateTrigger set value false | |||
There was a problem hiding this comment.
Suggested change
| data modify storage api: Argument.ActivateTrigger set value false | |
| data modify storage api: Argument.ApplyTrigger set value false |
| @@ -14,6 +14,7 @@ | |||
| data modify storage api: Argument.AttackType set value "Physical" | |||
| data modify storage api: Argument.AdditionalMPHeal set from storage asset:context this.AdditionalMPHeal | |||
| execute as @a if score @s UserID = $UserID Temporary run function api:damage/modifier | |||
| data modify storage api: Argument.ActivateTrigger set value false | |||
There was a problem hiding this comment.
Suggested change
| data modify storage api: Argument.ActivateTrigger set value false | |
| data modify storage api: Argument.ApplyTrigger set value false |
| data modify storage api: Argument.Heal set from storage asset:context this.Heal | ||
| execute as @a if score @s UserID = $UserID Temporary run function api:heal/modifier | ||
| function api:heal/ | ||
| data modify storage api: Argument.ActivateTrigger set value false |
There was a problem hiding this comment.
Suggested change
| data modify storage api: Argument.ActivateTrigger set value false | |
| data modify storage api: Argument.ApplyTrigger set value false |
Comment on lines
10
to
12
| # 周囲のプレイヤーにウィザー | ||
| effect give @a[gamemode=!spectator,distance=..1.2] wither 1 2 false | ||
| execute as @a[gamemode=!spectator,distance=..1.2] run function asset:mob/0058.divide_haze/tick/wither | ||
|
|
There was a problem hiding this comment.
これ、修正前の処理っぽいのでconflictしてそう
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #846
Fix #724
Fix #725
Fix #820
Related #1064
Blocked by ProjectTSB/TheSkyBlessing#1840