Skip to content

Added basic support for redis sentinel based on https://github.com/Namoshek/laravel-redis-sentinel #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Jacq
Copy link

@Jacq Jacq commented Apr 12, 2025

Merged and refactor code with from old fork #https://github.com/ml65/prometheus_client_php that supports redis sentinel by updating master address/port options before redis connections.

@LKaemmerling
Copy link
Member

Hey, thank you for your work. Would it be possible to add tests based on https://hub.docker.com/r/bitnami/redis-sentinel (see our https://github.com/PromPHP/prometheus_client_php/blob/main/.github/workflows/tests.yml)?

@Jacq
Copy link
Author

Jacq commented Apr 17, 2025

Hey, thank you for your work. Would it be possible to add tests based on https://hub.docker.com/r/bitnami/redis-sentinel (see our https://github.com/PromPHP/prometheus_client_php/blob/main/.github/workflows/tests.yml)?

Already added some test and performed a full refactor based on a different repo, using phpredis sentinel support.
Still need to fix the Redis version matrix test

@Jacq Jacq force-pushed the main branch 2 times, most recently from e1a542d to e531f94 Compare April 18, 2025 17:19
@Jacq
Copy link
Author

Jacq commented Apr 18, 2025

Added tests, ready to merge.
It was tricky to include Redis sentinel service as redis5 does not support resolve hostname.

@Jacq Jacq changed the title Added basic support for redis sentinel Added basic support for redis sentinel based on https://github.com/Namoshek/laravel-redis-sentinel Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants