Add Predis support #186
Open
Add Predis support #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtk3d
changed the title
mtk3d
changed the title
mtk3d
force-pushed
the
feature/add-predis-support
branch
5 times, most recently
from
74a8188 to
bdbd3f9
Compare
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
mtk3d
force-pushed
the
feature/add-predis-support
branch
from
bdbd3f9 to
a3c7a3e
Compare
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
Signed-off-by: Mateusz Cholewka <[email protected]>
|
Ok, it's ready now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I've introduced changes to support Predis as an alternative Redis connection adapter, while maintaining full backward compatibility and avoiding code duplication.
This was achieved by introducing a minimal RedisClient interface, designed according to the YAGNI principle. It only exposes the necessary methods required by the prometheus adapter.
AbstractRedis.php is basically all redis generic logic moved from Redis.php
I know there already is a PR with predis but it seems abandoned.
I see there is still need to have support for predis, also I need one for my project. So I decided to make this one, and I’m ready to help bring it across the finish line 😄
All tests are passing locally, and the code style checks are green, so I hope there will be no issues in pipeline.