Lira Integration#3
Merged
Merged
Conversation
Contributor
Author
|
@belovdv I'm waiting for your review and/or approval of the Rust library and uploading this first integration MR. |
Contributor
Author
|
Relates #3 |
Closed
* Added module w/ Standard LIRA Operations * Formatted w/ black
* IR Value object was added * Sequence/Snippet/Instruction/Architecture Builders were added
* YAML serialization was supported in python integration test
* serialization/deserialization logic moved into classes * to_h/from_h ctors were added into Arch/IR data structures
* YAML Normalization script to provide cross-library check on examples/tests
* Introduced BaseOp enum
* LIRA TXT serlialization was deprecated
* Integration test updated
- TXT format was removed
- Normalization was applied on script output
- Launch README added
* test_ir_ser.py was temporary removed
* LIRA YAML serialization updated to fit with unified format
* LIRA TXT serlialization was deprecated
* Integration test updated
- TXT format was removed
- Normalization was applied on script output
* Introduced LIRA Base Operations
* Introduced LIRA YAML serialization
* Register abstraction added into arch.rs
* Introduced LIRA IR Builder (general & arch-specific)
* LIRA TXT serlialization was deprecated
* Integration test updated
- TXT format was removed
- Normalization was applied on script output
- Launch README added
* Root Cargo.toml updated * Cargo.toml added examples/ * CLI added into example usage
* Constant mask of the instruction was added into InstructionEncoding * Examples were updated
uslsteen
added
Ruby
belovdv
reviewed
Jun 18, 2026
belovdv
left a comment
belovdv
left a comment
Collaborator
There was a problem hiding this comment.
Conclusion
I'm stopping the detailed review for now. Comments already made are mostly nitpicks, but there are some crucial blockers - however, that's not the main issue.
The real problem right now is the lack of a shared strategic vision for this framework.
We need to align on the general goals and the problems we're solving. Then decide on the why, what, and how at a high level. Only after we reach agreement should we circle back to the implementation.
Also, I'd much rather we add things piece by piece - CI, new file format, directory layout, tests, standard operations, IR builder. Because of the nature of this project, imo we should work on one feature at a time, but for all languages (that need it) simultaneously.
* IR Builder & IR Base Ops was removed (only on scripting site) * Unit tests were removed * LIRA Infra Update
* Crutch wih sys.path.insert was totally removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial LIRA IR libraries