Fixes our NBT crate #486
Open
Fixes our NBT crate #486
+232
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh very nice, I wonder if you can may replace fastnbt now with our nbt crate ? |
asodugf12
changed the title
from_bytes throwing split_to out of bounds error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the code that consumes the name, because it only consumes 1 byte instead of the full 2 byte length and the name itself. This causes the code to split the string at a position way bigger than the buffer itself could hold.
The new code instead skips the bytes that store the name, however this could be simply changed to return the name if it is needed.
Also updates our serializer to correctly serialize NBT Lists
Fixes #420
(Partially)