Implement Bulk Loading/Writing for Chunks #535
Draft
+727
−653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment and use exception to know if file exist
…improved usability
… and adjust file truncation logic
… in LinearFile and tmp filenames on write
… management logic
Snowiiii
reviewed
Feb 9, 2025
| pub enum Compression { | ||
| /// GZip Compression | ||
| GZip = 1, | ||
| /// ZLib Compression | ||
| ZLib = 2, | ||
| /// Uncompressed (since a version before 1.15.1) | ||
| #[default] | ||
| Uncompressed = 3, |
There was a problem hiding this comment.
I don't like this, We had this before already. But it actually makes no sense to have "No Compression" in an Compression enum, Also now we have to use convert the input data to vec when uncompressed
There was a problem hiding this comment.
I have no problem to let it as before but, if the code 3exists and means something specific, even documented officially (https://minecraft.wiki/w/Region_file_format). Dont we should have it well represented on code? this way we dont need to manage where we use the compression struct. And also NoCompression can be a "zero runtime cost but no memory footprint improve version". Whatever you choose its good for me, i just thought it was desirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement the Bulk API for chunks loading/writing with some function changes that get leverage of the bulk operation (like reducing allocations, locks and more).
Also this includes some Anvil refactor and the creation of a Traits/API that can be re-used on entity storage system and to implements diferents Writers/Loaders (as DB cached, one that use in Cloud Storage or more optimizations).