Permissions support #560
Permissions support #560
Conversation
|
Just found out that when no commands are registered the Server Crashes on /help Messed the permission Level and Operator Status on /help. Fixing that |
|
One thing I'd maybe consider implementing is namespaces for these permissions. Specifically for use with plugins so that there aren't any collisions. Each plugin has a plugin name, which has to conform to the Cargo naming system. In this way we can prevent conflicts in permissions (like if two plugins both wanted to register a |
1 similar comment
|
One thing I'd maybe consider implementing is namespaces for these permissions. Specifically for use with plugins so that there aren't any collisions. Each plugin has a plugin name, which has to conform to the Cargo naming system. In this way we can prevent conflicts in permissions (like if two plugins both wanted to register a |
|
That's actually a very good idea. Will definitely implement and leave a option to enable it |
Server does not crash when no commands are registered. Tab completions do not leak commands that the player is not authorized to
| @@ -165,13 +163,32 @@ impl CommandDispatcher { | |||
|
|
|||
| let Some(permission) = self.permissions.get(key) else { | |||
| return Err(GeneralCommandIssue( | |||
| "Permission for Command not found".to_string(), | |||
| "Permission for Command not found 0".to_string(), | |||
There was a problem hiding this comment.
| "Permission for Command not found 0".to_string(), | |
| "Permission for command {key} not found".to_string(), |
..?
| "pumpkin.playsound", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register( | ||
| title::init_command_tree(), | ||
| "pumpkin.title", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register( | ||
| summon::init_command_tree(), | ||
| "pumpkin.summon", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register( | ||
| experience::init_command_tree(), | ||
| "pumpkin.experience", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register( | ||
| weather::init_command_tree(), | ||
| "pumpkin.weather", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register( | ||
| particle::init_command_tree(), | ||
| "pumpkin.particle", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register( | ||
| damage::init_command_tree(), | ||
| "pumpkin.damage", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register( | ||
| bossbar::init_command_tree(), | ||
| "pumpkin.bossbar", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register(say::init_command_tree(), "pumpkin.say", PermissionLvl::Two); | ||
| dispatcher.register( | ||
| gamemode::init_command_tree(), | ||
| "pumpkin.gamemode", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register( | ||
| transfer::init_command_tree(), | ||
| "pumpkin.transfer", | ||
| PermissionLvl::Two, | ||
| ); | ||
| dispatcher.register(op::init_command_tree(), "pumpkin.op", PermissionLvl::Three); | ||
| dispatcher.register( | ||
| deop::init_command_tree(), | ||
| "pumpkin.deop", | ||
| PermissionLvl::Three, | ||
| ); | ||
| dispatcher.register( | ||
| kick::init_command_tree(), | ||
| "pumpkin.kick", | ||
| PermissionLvl::Three, | ||
| ); | ||
| dispatcher.register( | ||
| plugin::init_command_tree(), | ||
| "pumpkin.plugin", | ||
| PermissionLvl::Three, | ||
| ); | ||
| dispatcher.register( | ||
| plugins::init_command_tree(), | ||
| "pumpkin.plugins", | ||
| PermissionLvl::Three, | ||
| ); | ||
| dispatcher.register( | ||
| ban::init_command_tree(), | ||
| "pumpkin.ban", | ||
| PermissionLvl::Three, | ||
| ); | ||
| dispatcher.register( | ||
| banip::init_command_tree(), | ||
| "pumpkin.banip", | ||
| PermissionLvl::Three, | ||
| ); | ||
| dispatcher.register( | ||
| banlist::init_command_tree(), | ||
| "pumpkin.banlist", | ||
| PermissionLvl::Three, | ||
| ); | ||
| dispatcher.register( | ||
| pardon::init_command_tree(), | ||
| "pumpkin.pardon", | ||
| PermissionLvl::Three, | ||
| ); | ||
| dispatcher.register( | ||
| pardonip::init_command_tree(), | ||
| "pumpkin.pardonip", | ||
| PermissionLvl::Three, | ||
| ); | ||
| dispatcher.register( | ||
| stop::init_command_tree(), | ||
| "pumpkin.stop", | ||
| PermissionLvl::Four, | ||
| ); |
There was a problem hiding this comment.
Can you clean this up using a list for each level, containing every command that requires this level?
Description
Adds support for traditional permissions.
For larger servers, a robust permission system is essential, ideally one that supports existing solutions already using the traditional permissions format.
Changes
Testing
Please follow our Coding Guidelines