-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Become compatible with flake8 5.0.0 #259
Conversation
warnings.warn( | ||
( | ||
"flake8-pyi will drop support for running with flake8 < 5.0.0 " | ||
"in a future version. This will not happen until November 2022 " | ||
"at the earliest." | ||
), | ||
category=FutureWarning, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually verified that this warning is emitted if the plugin is run in an environment with flake8==4.x
installed. Other than that, the test suite still passes for me locally with flake8==4.x
installed.
Thanks both for the reviews! |
I understand that I am late to the party, but please reconsider this.
Here's what we do for now:
|
Hey @sobolevn! Sorry to hear this has been causing pain :( Very happy to be flexible here. I understand there's a bit of an Could you be specific about what exactly is causing problems from |
Requiring Definition: https://github.com/PyCQA/flake8/blob/b220ee957aca37ae5919509f6f25dd571a836d52/setup.cfg#L44 |
Cool. So would it "fix" it for you if we extended the period before we drop support for I'd prefer the first option ideally, but either could be doable :) |
I think that dropping older versions of flake8 is fine when 3.7 is dropped. |
Fixes #257