Migrate cffi bindings to new BindingGenerator trait
#2876
Merged
+67
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the cffi binding generation to use the new BindingGenerator trait pattern, aligning it with the existing PyO3 implementation. This creates a more consistent and maintainable architecture for handling different binding types.
Key Changes:
- Migrated
write_cffi_modulefunction toCffiBindingGeneratorstruct implementingBindingGeneratortrait - Updated
build_context.rsto usegenerate_bindingwith the new generator instead of callingwrite_cffi_moduledirectly - Added
.write(true)option to file creation ingenerate_bindingfor clarity
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/build_context.rs | Updated to instantiate CffiBindingGenerator and use the unified generate_binding function |
| src/binding_generator/mod.rs | Exported CffiBindingGenerator instead of write_cffi_module function, improved file creation options |
| src/binding_generator/cffi_binding.rs | Refactored into trait-based CffiBindingGenerator struct implementing BindingGenerator |
messense
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.