Skip to content

Always emit deprecation warning for 'upload' and 'publish' #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2025
Merged

Always emit deprecation warning for 'upload' and 'publish' #2879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions src/upload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,17 @@ impl PublishOpt {

/// Set to non interactive mode if we're running on CI
pub fn non_interactive_on_ci(&mut self) {
if !self.non_interactive && env::var("CI").map(|v| v == "true").unwrap_or_default() {
let msg = "⚠️ Warning: The maturin upload and publish commands are deprecated and will be removed in the future. For more information see: https://github.com/PyO3/maturin/issues/2334";
eprintln!("{msg}");

if env::var("GITHUB_ACTIONS")
.map(|v| v == "true")
.unwrap_or_default()
{
// Also emit a warning annotation on the GH action
println!("::warning::{msg}");
}
let msg = "⚠️ Warning: The maturin upload and publish commands are deprecated and will be removed in the future. For more information see: https://github.com/PyO3/maturin/issues/2334";
eprintln!("{msg}");
if env::var("GITHUB_ACTIONS")
.map(|v| v == "true")
.unwrap_or_default()
{
// Also emit a warning annotation on the GH action
println!("::warning::{msg}");
}

if !self.non_interactive && env::var("CI").map(|v| v == "true").unwrap_or_default() {
eprintln!("🎛️ Running in non-interactive mode on CI");
self.non_interactive = true;
}
Expand Down
Loading