-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement PyListMethods
#3680
implement PyListMethods
#3680
Conversation
CodSpeed Performance ReportMerging #3680 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit w.r.t. documentation, otherwise LGTM.
Thanks for all these reviews 🙏 I think my next step today is to write a high-level summary of the tasks remaining before I think we can release this API, so that we all have a sense of progress (and can coordinate picking up items in parallel if desired). |
Split from #3606
Follows the same patterns we've seen in #3675 for the gil-ref iterator to wrap the new iterator. I think this is again extremely mechanical.