Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore derive(Debug) for ffi types where it was removed #4438

Merged
merged 1 commit into from
Aug 14, 2024
Merged

restore derive(Debug) for ffi types where it was removed #4438

merged 1 commit into from
Aug 14, 2024

Conversation

ngoldbaum
Copy link
Contributor

I was looking over #4434 and realized I incorrectly removed Debug from a number of structs in the ffi in that PR. This restores it.

@ngoldbaum ngoldbaum added the CI-skip-changelog Skip checking changelog entry label Aug 13, 2024
davidhewitt
davidhewitt approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind too much about these impls, but I guess it would be unintentionally breaking to remove them. Thanks for being diligent!

@davidhewitt davidhewitt added this pull request to the merge queue Aug 14, 2024
Merged via the queue into PyO3:main with commit ffeb901 Aug 14, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngoldbaum @davidhewitt