fix flaky tests on free-threaded build #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
reviewed
Sep 26, 2024
tests/test_gc.rs
Outdated
Comment on lines
84
to
87
| #[cfg(not(Py_GIL_DISABLED))] | ||
| assert!(drop_called1.load(Ordering::Relaxed)); | ||
| #[cfg(not(Py_GIL_DISABLED))] | ||
| assert!(drop_called2.load(Ordering::Relaxed)); |
There was a problem hiding this comment.
This test doesn't rely on a __clear__ function, so I think shouldn't be flaky with gc. Was this change out of an abundance of caution or because you did observe flakiness?
tests/test_gc.rs
Outdated
Comment on lines
241
to
244
| #[cfg(not(Py_GIL_DISABLED))] | ||
| assert!(drop_called1.load(Ordering::Relaxed)); | ||
| #[cfg(not(Py_GIL_DISABLED))] | ||
| assert!(drop_called2.load(Ordering::Relaxed)); |
There was a problem hiding this comment.
Similarly no __clear__ / gc integration here.
|
Thanks for pointing that out, that was me misunderstanding rather than being overzealous. |
davidhewitt
approved these changes
Sep 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These asserts should all be skipped for the same reason as the assert that's skipped already.
Also moved the explanation to the docstring for the struct we use for this.