Optimize Iterator::last() for PyList & PyTuple and Iterator::count() for PyDict, PyList, PyTuple & PySet
#4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
force-pushed
the
optimize-iter-last
branch
3 times, most recently
from
0e09836 to
cbdca14
Compare
bschoenmaeckers
changed the title
Iterator:last() for PyList & PyTupleIterator::last() for PyList & PyTuple
bschoenmaeckers
force-pushed
the
optimize-iter-last
branch
from
380b184 to
482525b
Compare
bschoenmaeckers
changed the title
Iterator::last() for PyList & PyTupleIterator::last() for PyList & PyTuple and Iterator::count() for PyDict, PyList, PyTuple & PySet
bschoenmaeckers
force-pushed
the
optimize-iter-last
branch
from
482525b to
8bc30f9
Compare
bschoenmaeckers
force-pushed
the
optimize-iter-last
branch
from
8bc30f9 to
873070a
Compare
|
Maybe we can extend/modify the tests a bit to get some coverage on these new implementations? |
bschoenmaeckers
force-pushed
the
optimize-iter-last
branch
from
873070a to
2f5a4a5
Compare
|
Added some tests |
bschoenmaeckers
force-pushed
the
optimize-iter-last
branch
from
2f5a4a5 to
7fc23f7
Compare
|
Great, thank you very much 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements #4810
Part of #4787