docs: Removed references to unmaintained pyo3-asyncio crate #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjoel
changed the title
Icxolu
reviewed
Feb 22, 2025
There was a problem hiding this comment.
I deleted the examples because I didn't have time to update and test them all. Additionally the pyo3-async-runtime docs include many examples so it doesn't seem very necessary to duplicate them here, and doing so would put more burden on future maintainers to keep them updated.
I think that makes sense. Without a proper solution to test these, they will get outdated again. Maintaining the examples as part pyo3-async-runtimes and directing people there seems a lot easier.
peterjoel
force-pushed
the
asyncio-docs
branch
from
e8041d0 to
6a813cf
Compare
Icxolu
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the old
pyo3-asynciolinks topyo3-async-runtime.These parts of the documentation were very out of date (working with pyo3 0.14 while the current version is 0.23) and the examples were therefore broken.
The main purpose here is to prevent anyone else wasting time and effort from being directed towards
pyo3-asyncioinstead ofpyo3-async-runtime.I deleted the examples because I didn't have time to update and test them all. Additionally the
pyo3-async-runtimedocs include many examples so it doesn't seem very necessary to duplicate them here, and doing so would put more burden on future maintainers to keep them updated.