add a MutexExt trait to avoid deadlocks using Mutex::lock() #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
force-pushed
the
mutex-ext
branch
2 times, most recently
from
aa42fca to
c4de919
Compare
Icxolu
reviewed
Feb 25, 2025
davidhewitt
reviewed
Feb 26, 2025
| &self, | ||
| _py: Python<'_>, | ||
| ) -> std::sync::LockResult<std::sync::MutexGuard<'_, T>> { | ||
| // SAFETY: detach from the runtime right before a possibly blocking call |
There was a problem hiding this comment.
Instead of unconditionally detaching, is it worth calling self.try_lock() first, and returning eagerly in all cases except where it would block? (And then if it would block, continue to the code below.)
There was a problem hiding this comment.
I guess it can't hurt to avoid detaching and reattaching if it's possible. I'll go ahead and do that.
davidhewitt
approved these changes
Feb 27, 2025
Co-authored-by: David Hewitt <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like a network error. One more try… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4771.
I couldn't find any good uses for this inside PyO3 itself, but we know of at least two spots in rust-numpy this would be useful.