add RwLockExt trait
#5435
Merged
add RwLockExt trait
#5435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
force-pushed
the
rwlockext_trait
branch
2 times, most recently
from
f9ae19c to
e36ab53
Compare
|
|
tdyas
added a commit
to pantsbuild/pants
that referenced
this pull request
Sep 16, 2025
Upgrade the `pyo3` crate to v0.26.0. There are several migrations due to deprecated naming [as per the migration guide](https://pyo3.rs/main/migration.html#from-025-to-026): - The `PyObject` type alias is removed. Switched to its expansion `Py<PyAny>`. - "GIL" is removed as a legacy name since the free-threaded Python in Python 3.13+ has no GIL. Threads still "attach" to the interpreter though so `Python::with_gil` becomes `Python::attach` and `Python::allow_threads` becomes `Python::detach`. - The `GILProtected` wrapper is removed in favor of just using normal `Mutex` or `RwLock` locks. The various usages have been switched to `Mutex` and `RwLock`. There is a very small chance of acquiring a lock deadlocking with the GIL so PyO3 provides a helper `lock_py_attached` method to detach, acquire the lock, and reattach. For the `RwLock` used in `PyGeneratorResponseCall`, equivalent `read_py_attached` and `write_py_attached` methods won't be available until my PR PyO3/pyo3#5435 lands upstream. - `pyo3::prepare_freethreaded_python` becomes `Python::initialize`.
tdyas
force-pushed
the
rwlockext_trait
branch
from
b3a5b14 to
2c7294c
Compare
tdyas
force-pushed
the
rwlockext_trait
branch
from
2c7294c to
055aac3
Compare
davidhewitt
reviewed
Oct 11, 2025
There was a problem hiding this comment.
Thanks for updating this branch today and sorry for the very slow review.
Overall this looks great, and is I think good for merge without any question about the validity of the design.
Just a few minor nits which would be great to clean up before we merge and ship.
|
Thanks so much for doing this! Sorry for missing this PR - if you have future PRs that are related to supporting or improving multithreaded workflows please feel free to ping my handle for speedier reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
pyo3::sync::RwLockExttrait forstd::sync::RwLockto detach from the Python interpreter while blocking to acquire a read or write lock on astd::sync::RwLock. This mirrors whatpyo3::sync::MutexExtandpyo3::sync::OnceLockExtdo forstd::sync::Mutexandstd::sync::OnceLockrespectively. The trait is also implemented forparking_lot's /lock_api'sRwLock.