온보딩 화면 구현 #104
Merged
온보딩 화면 구현 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteHyun
previously approved these changes
Mar 19, 2024
PyeonHaeng-iOS/Sources/Scenes/OnboardingScene/OnboardingView.swift
Outdated
Show resolved
Hide resolved
PyeonHaeng-iOS/Sources/Scenes/OnboardingScene/OnboardingView.swift
Outdated
Show resolved
Hide resolved
WhiteHyun
reviewed
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots 📸
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-18.at.19.33.02.mp4
고민, 과정, 근거 💬
구현 목록
OnboardingViewModel을 삭제하고 View에서 바로 배열의 인덱스를 참조하는 방법으로 변경했습니다.isFirstLaunch라는 변수를 통해 온보딩 화면의 유무를 제어했습니다.References 📋