Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductInfo ๋ฐ์ดํ„ฐ๐Ÿ”„๋ทฐ ๋ฐ”์ธ๋”ฉ #53

Merged
merged 13 commits into from
Feb 26, 2024

Conversation

eung7
Copy link
Contributor

@eung7 eung7 commented Feb 24, 2024

Screenshots ๐Ÿ“ธ

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-25.at.00.27.59.mp4

๊ณ ๋ฏผ, ๊ณผ์ •, ๊ทผ๊ฑฐ ๐Ÿ’ฌ

  • View์— ๋Œ€ํ•œ ๊ตฌ์กฐํ™”๋ฅผ ์ง„ํ–‰ํ•˜๊ณ  ๋ฐ์ดํ„ฐ๋ฅผ UI ๋ฐ”์ธ๋”ฉ ์ž‘์—…์„ ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค.

DetailProduct, Mock initializer ์ „์—ญ์  ์ถ”๊ฐ€

  • ๊ธฐ์กด ํ”ผ๋“œ๋ฐฑ ์ฃผ์…จ๋˜ DetailProduct์˜ Mock initializer๋ฅผ ๋‹ค๋ฅธ ๊ณณ์—์„œ๋„ ์“ฐ์ด๋Š” ๊ด€๊ณ„๋กœ ์ „์—ญ์ ์œผ๋กœ ๋งŒ๋“ค๊ฒŒ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

View ๊ตฌ์กฐํ™”

  • ๊ธฐ์กด ๊ฐ€๋…์„ฑ์ด ์ข‹์ง€ ์•Š์€ ๊ฒƒ์„ ์ˆ˜์ •ํ•˜์—ฌ ๊ตฌ์กฐํ™”๋ฅผ ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ตœ๋Œ€ํ•œ ๋ถ„๋ฆฌํ•  ์ˆ˜ ์žˆ๋Š” View๋“ค์€ ๋ถ„๋ฆฌํ•˜์—ฌ ํ•˜์œ„๋ทฐ๋ฅผ ์—ฌ๋Ÿฟ ๋งŒ๋“ค์—ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ธฐ์กด calculatePoints๊ฐ™์€ ๋ฌด๊ฑฐ์šด ์ž‘์—…๋“ค์ด ์—ฌ๋Ÿฌ ๋ฒˆ ํ˜ธ์ถœ๋˜๋Š” ๊ฒƒ์„ ๊ณ ์ณค์Šต๋‹ˆ๋‹ค.

ํŠนํžˆ ProductInfoLineGraphView๋Š” View์˜ Frame์„ ๋ฐ›์•„์„œ UI๋ฅผ ๊ทธ๋ฆฌ๋‹ค๋ณด๋‹ˆ
ViewModel์—์„œ ๋ฐ์ดํ„ฐ๊ฐ€ ๋“ค์–ด์˜ค๋Š” ํƒ€์ด๋ฐ๊ณผ ๋ทฐ์˜ ๋ผ์ดํ”„ ์‚ฌ์ดํด์„ ๋”ฐ๋ผ ๊ฐ€๋Š” ๊ฒƒ์ด ์ƒ๊ฐ๋ณด๋‹ค ๋ณต์žกํ–ˆ์Šต๋‹ˆ๋‹ค.
์ผ๋‹จ ์ง€๊ธˆ์€ ์ •์ƒ์ž‘๋™ํ•˜์ง€๋งŒ, ์ถ”ํ›„ ๋„คํŠธ์›Œํฌ ์ง€์—ฐ ๋ฐ ์ƒˆ๋กœ๊ณ ์นจ ๋“ฑ ๋‹ค์–‘ํ•œ ์ƒํ™ฉ ์†์—์„œ ๋†“์น˜๋Š” ๋ถ€๋ถ„์ด ์žˆ์„ ์ˆ˜๋„ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐ๋ฉ๋‹ˆ๋‹ค.

References ๐Ÿ“‹




@eung7 eung7 added ๐Ÿช Products Products View ๐Ÿ”จ Implementation New feature or request labels Feb 24, 2024
@eung7 eung7 added this to the v2.0.0 milestone Feb 24, 2024
@eung7 eung7 requested a review from a team February 24, 2024 15:38
@eung7 eung7 self-assigned this Feb 24, 2024
Copy link
Member

@WhiteHyun WhiteHyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@WhiteHyun WhiteHyun merged commit c3c07cf into main Feb 26, 2024
2 checks passed
@WhiteHyun WhiteHyun deleted the feature/productinfo/48 branch February 26, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ”จ Implementation New feature or request ๐Ÿช Products Products View
Projects
2 participants