Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

설정 화면 - 공지 화면 구현 #88

Merged
merged 2 commits into from
Mar 7, 2024
Merged

설정 화면 - 공지 화면 구현 #88

merged 2 commits into from
Mar 7, 2024

Conversation

WhiteHyun
Copy link
Member

@WhiteHyun WhiteHyun commented Mar 7, 2024

Screenshots 📸

공지 화면



고민, 과정, 근거 💬

  • 아직 다크모드 정리가 안되어있는 것 같아요. 색상이 너무 어둡네요..ㅎ
  • SettingsView의 각 아이템들을 어떻게 정리해서 뷰를 그려줘야할까 고민입니다. enumeration을 사용하긴 했는데, 나중에 새로이 설정 옵션이 생기게 된다면 일일히 수정하는 게 번거로울 것 같아서 protocol을 이용한 방식을 생각해보았습니다만, 테스트하던 중 associatedtype에 막혀버렸습니다. 🥲 그래서 우선 롤백하고 기존 enumereation 그대로 사용했습니다.




@WhiteHyun WhiteHyun added ⚙️ Settings Settings View 🔨 Implementation New feature or request labels Mar 7, 2024
@WhiteHyun WhiteHyun added this to the v2.0.0 milestone Mar 7, 2024
@WhiteHyun WhiteHyun requested a review from a team March 7, 2024 11:42
@WhiteHyun WhiteHyun self-assigned this Mar 7, 2024
Copy link
Contributor

@eung7 eung7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요! 더 좋은 방법을 찾기 전까지는 enumration이 가장 나아보이긴 하네요!

@eung7 eung7 merged commit 50b15ea into main Mar 7, 2024
6 checks passed
@eung7 eung7 deleted the feature/settings/87 branch March 7, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Implementation New feature or request ⚙️ Settings Settings View
Projects
Development

Successfully merging this pull request may close these issues.

공지사항을 눌렀을 때 공지사항 리스트 UI를 보여준다.
2 participants