Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plomin deser #420

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Plomin deser #420

merged 5 commits into from
Feb 1, 2025

Conversation

cffls
Copy link
Collaborator

@cffls cffls commented Jan 27, 2025

Updates for new serializations introduced in Conway/Plomin HF. With this change, fields affected by new serialization spec will be encoded in the new format (tag.258) by default.

Spec reference: https://github.com/IntersectMBO/cardano-ledger/blob/9d65b0d9d1fb0a88f9a31cf2cdc684744e66dcea/eras/conway/impl/cddl-files/extra.cddl#L5-L12

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 92.48120% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.04%. Comparing base (f21348f) to head (57bc0de).

Files with missing lines Patch % Lines
pycardano/serialization.py 87.50% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   87.42%   84.04%   -3.39%     
==========================================
  Files          32       31       -1     
  Lines        4341     4355      +14     
  Branches     1096     1102       +6     
==========================================
- Hits         3795     3660     -135     
- Misses        394      554     +160     
+ Partials      152      141      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cffls cffls merged commit 7300341 into main Feb 1, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant