2024 12 11 fix ara bauwerk export 2nd attempt #184

sjib · 2024-12-11T13:19:59Z

replaces #178
rebased on master (11.12.2024)

sjib · 2024-12-12T09:05:56Z

Ein Fehler trat bei der Ausführung von Python-Code auf: 

AttributeError: 'QgepExportUtils' object has no attribute 'export_organisation' 
Traceback (most recent call last):
  File "C:\Users/Stefan/AppData/Roaming/QGIS/QGIS3\profiles\testingdev165_2/python/plugins\qgepplugin\qgepqwat2ili\qgepqwat2ili\gui\__init__.py", line 672, in action_do_export
    qgep_export_sia405(
  File "C:\Users/Stefan/AppData/Roaming/QGIS/QGIS3\profiles\testingdev165_2/python/plugins\qgepplugin\qgepqwat2ili\qgepqwat2ili\qgepsia405\export.py", line 195, in qgep_export_sia405
    qgep_export_utils.export_organisation()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'QgepExportUtils' object has no attribute 'export_organisation'

sjib · 2024-12-12T09:18:52Z

File "/home/runner/work/qgepqwat2ili/qgepqwat2ili/qgepqwat2ili/qgepsia405/export.py", line 125, in qgep_export_sia405
    subset_wws_ids = remove_from_selection(subset_wws_ids, ws_off_sia405abwasser_list)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/qgepqwat2ili/qgepqwat2ili/qgepqwat2ili/utils/qgep_export_utils.py", line 483, in remove_from_selection
    for list_item in remove_ids:
                     ^^^^^^^^^^
TypeError: 'NoneType' object is not iterable

sjib · 2024-12-12T10:05:33Z

Ein Fehler trat bei der Ausführung von Python-Code auf: 

sqlalchemy.exc.ArgumentError: ON clause, typically a SQL expression or ORM relationship attribute expected, got . 
Traceback (most recent call last):
  File "C:\Users/Stefan/AppData/Roaming/QGIS/QGIS3\profiles\testingdev165_2/python/plugins\qgepplugin\qgepqwat2ili\qgepqwat2ili\gui\__init__.py", line 672, in action_do_export
    qgep_export_sia405(
  File "C:\Users/Stefan/AppData/Roaming/QGIS/QGIS3\profiles\testingdev165_2/python/plugins\qgepplugin\qgepqwat2ili\qgepqwat2ili\qgepsia405\export.py", line 357, in qgep_export_sia405
    qgep_export_utils.export_dryweather_downspout()
  File "C:\Users/Stefan/AppData/Roaming/QGIS/QGIS3\profiles\testingdev165_2/python/plugins\qgepplugin\qgepqwat2ili\qgepqwat2ili\utils\qgep_export_utils.py", line 564, in export_dryweather_downspout
    query = query.join(
            ^^^^^^^^^^^
  File "", line 2, in join
  File "C:\Users\Stefan\AppData\Roaming\Python\Python312\site-packages\sqlalchemy\sql\base.py", line 279, in _generative
    x = fn(self, *args, **kw)
        ^^^^^^^^^^^^^^^^^^^^^
  File "", line 2, in join
  File "C:\Users\Stefan\AppData\Roaming\Python\Python312\site-packages\sqlalchemy\orm\base.py", line 306, in generate
    fn(self, *args, **kw)
  File "C:\Users\Stefan\AppData\Roaming\Python\Python312\site-packages\sqlalchemy\orm\query.py", line 2429, in join
    onclause_element = coercions.expect(
                       ^^^^^^^^^^^^^^^^^
  File "C:\Users\Stefan\AppData\Roaming\Python\Python312\site-packages\sqlalchemy\sql\coercions.py", line 395, in expect
    resolved = impl._literal_coercion(
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Stefan\AppData\Roaming\Python\Python312\site-packages\sqlalchemy\sql\coercions.py", line 909, in _literal_coercion
    self._raise_for_expected(element)
  File "C:\Users\Stefan\AppData\Roaming\Python\Python312\site-packages\sqlalchemy\sql\coercions.py", line 518, in _raise_for_expected
    raise exc.ArgumentError(msg, code=code) from err
sqlalchemy.exc.ArgumentError: ON clause, typically a SQL expression or ORM relationship attribute expected, got .

for more information, see https://pre-commit.ci

sjib · 2024-12-12T12:54:55Z

Selection with ARABauwerk works

241212qgep-export_sel_arabw_SIA405_ABWASSER_2015_LV95.zip

sjib · 2024-12-12T12:55:53Z

 Traceback (most recent call last):
  File "/home/runner/work/qgepqwat2ili/qgepqwat2ili/qgepqwat2ili/tests/test_qgep.py", line 232, in test_case_f_export_selection_sia405
    main(
  File "/home/runner/work/qgepqwat2ili/qgepqwat2ili/qgepqwat2ili/__init__.py", line 214, in main
    qgep_export_sia405(
  File "/home/runner/work/qgepqwat2ili/qgepqwat2ili/qgepqwat2ili/qgepsia405/export.py", line 86, in qgep_export_sia405
    adapted_subset_ids = add_to_selection(adapted_subset_ids, connected_overflow_to_wn_ids)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/qgepqwat2ili/qgepqwat2ili/qgepqwat2ili/utils/qgep_export_utils.py", line 1190, in add_to_selection
    for list_item in add_ids:
                     ^^^^^^^
TypeError: 'NoneType' object is not iterable

for more information, see https://pre-commit.ci

…://github.com/QGEP/qgepqwat2ili into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

for more information, see https://pre-commit.ci

…://github.com/QGEP/qgepqwat2ili into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

for more information, see https://pre-commit.ci

…://github.com/QGEP/qgepqwat2ili into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

for more information, see https://pre-commit.ci

sjib · 2024-12-18T22:03:58Z

Why do selection and subset_ids_original get changed?

2024-12-18T23:02:48 qgepplugin.qgepqwat2ili.qgepqwat2ili.utils:reprint subset_ids_original: ['ch080qwzHA001343', 'ch080qwzAK001341', 'ch080qwzHA000146']
2024-12-18T23:02:48 qgepplugin.qgepqwat2ili.qgepqwat2ili.utils:reprint subset_ids: ['ch080qwzHA001343', 'ch080qwzAK001341', 'ch080qwzHA000146']

sjib · 2024-12-19T07:38:11Z

Should solve #177

for more information, see https://pre-commit.ci

…://github.com/QGEP/qgepqwat2ili into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

sjib · 2024-12-19T08:01:01Z

@ponceta This should be ready to be merged. Further enhancement are placed in new issues and will follow later so that we can make a relase 1.6.6 till tomorrow.

sjib · 2024-12-19T08:03:43Z

Needs #183 so that VSA-KEK export is also working correctly.

ponceta · 2024-12-19T09:31:25Z

@domi4484 could you have a look at this before merging?

sjib · 2024-12-20T12:46:56Z

Successful export of VSA-KEK:

sjib · 2024-12-20T13:02:25Z

sjib · 2024-12-20T13:09:56Z

to check: abwasserbauwerkRef and abwassernetzelementRef

DSS 282 / 199
DSS Selection SAA 8/6
DSS Selection wwtp 15 / 6
SIA405 Abwasser 283 / 0 - ERROR - to check code
SIA405 Abwasser selection SAA 7 / 4
SIA405 Abwasser selection wwtp 12/6

for more information, see https://pre-commit.ci

sjib · 2024-12-20T14:16:10Z

SIA405 Abwasser 253 / 193 ok
SIA405 Abwasser selection SAA 7 / 4 ok
SIA405 Abwasser selection wwtp 12/6 ok

sjib · 2024-12-20T14:17:35Z

@ponceta From my side ready to merge

sjib · 2024-12-20T21:08:43Z

Should also solve QGEP/QGEP#856

sjib self-assigned this Dec 11, 2024

sjib marked this pull request as draft December 11, 2024 13:20

sjib added the enhancement New feature or request label Dec 11, 2024

sjib and others added 3 commits December 12, 2024 13:41

import get_ws_ids

a2aa4e8

[pre-commit.ci] auto fixes from pre-commit.com hooks

feca9f9

for more information, see https://pre-commit.ci

correct query

988c2c1

sjib and others added 19 commits December 12, 2024 13:57

check on None for add_ids

a8bacad

add subset_wws_ids=subset_wws_ids,

829e1c4

functions check on None variables

9ce7d63

correct else intend

eab0fd7

add new selection code to dss export

0caa7d3

[pre-commit.ci] auto fixes from pre-commit.com hooks

698d256

for more information, see https://pre-commit.ci

add selection code to export kek

a12a723

Merge branch '2024-12-11-fix-ara-bauwerk-export-2nd-attempt' of https…

0bfe46c

…://github.com/QGEP/qgepqwat2ili into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

[pre-commit.ci] auto fixes from pre-commit.com hooks

b2d448a

for more information, see https://pre-commit.ci

adapt imports export kek

4767d96

Merge branch '2024-12-11-fix-ara-bauwerk-export-2nd-attempt' of https…

620b6cc

…://github.com/QGEP/qgepqwat2ili into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

clean up

4736971

[pre-commit.ci] auto fixes from pre-commit.com hooks

d73bbc0

for more information, see https://pre-commit.ci

adapt import export dss

9be15e6

Merge branch '2024-12-11-fix-ara-bauwerk-export-2nd-attempt' of https…

fe68d16

…://github.com/QGEP/qgepqwat2ili into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

[pre-commit.ci] auto fixes from pre-commit.com hooks

44028f6

for more information, see https://pre-commit.ci

correct intent of return statement

ca1b3ed

add : and comment

fd8de58

def get_selection_text_for_in_statement check if list is empty

8eb5752

set variables back to selection_extend = True, as current solution

3638cde

This was referenced Dec 19, 2024

Why do selection and subset_ids_original get changed? #187

Open

Add option to choose if selection should be automatically extended (current) or not (new option) #188

Open

pre-commit-ci bot and others added 3 commits December 19, 2024 07:40

[pre-commit.ci] auto fixes from pre-commit.com hooks

da232d4

for more information, see https://pre-commit.ci

update export kek

05a8e52

Merge branch '2024-12-11-fix-ara-bauwerk-export-2nd-attempt' of https…

a00ce7a

…://github.com/QGEP/qgepqwat2ili into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

sjib removed the request for review from domi4484 December 19, 2024 07:48

sjib added this to the Datamodel 1.6.4 Plugin 1.6.6 milestone Dec 19, 2024

ponceta requested a review from domi4484 December 19, 2024 09:30

ponceta closed this Dec 20, 2024

ponceta reopened this Dec 20, 2024

Merge branch 'master' into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

1e42ed4

ponceta mentioned this pull request Dec 20, 2024

Skip failing kek export test #189

Merged

Merge branch 'master' into 2024-12-11-fix-ara-bauwerk-export-2nd-attempt

91d551e

sjib and others added 2 commits December 20, 2024 15:08

adapt cases export_reach_point and export_reach_point_check_fk_in_subset

6f57ae0

[pre-commit.ci] auto fixes from pre-commit.com hooks

59d05a1

for more information, see https://pre-commit.ci

ponceta added the fix label Dec 20, 2024

ponceta merged commit d641adc into master Dec 20, 2024
5 checks passed

ponceta deleted the 2024-12-11-fix-ara-bauwerk-export-2nd-attempt branch December 20, 2024 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2024 12 11 fix ara bauwerk export 2nd attempt #184

2024 12 11 fix ara bauwerk export 2nd attempt #184

sjib commented Dec 11, 2024 •

edited

Loading

sjib commented Dec 12, 2024

sjib commented Dec 12, 2024

sjib commented Dec 12, 2024

sjib commented Dec 12, 2024

sjib commented Dec 12, 2024

sjib commented Dec 18, 2024

sjib commented Dec 19, 2024

sjib commented Dec 19, 2024

sjib commented Dec 19, 2024

ponceta commented Dec 19, 2024

sjib commented Dec 20, 2024

sjib commented Dec 20, 2024 •

edited

Loading

sjib commented Dec 20, 2024 •

edited

Loading

sjib commented Dec 20, 2024 •

edited

Loading

sjib commented Dec 20, 2024

sjib commented Dec 20, 2024

2024 12 11 fix ara bauwerk export 2nd attempt #184

2024 12 11 fix ara bauwerk export 2nd attempt #184

Conversation

sjib commented Dec 11, 2024 • edited Loading

sjib commented Dec 12, 2024

sjib commented Dec 12, 2024

sjib commented Dec 12, 2024

sjib commented Dec 12, 2024

sjib commented Dec 12, 2024

sjib commented Dec 18, 2024

sjib commented Dec 19, 2024

sjib commented Dec 19, 2024

sjib commented Dec 19, 2024

ponceta commented Dec 19, 2024

sjib commented Dec 20, 2024

sjib commented Dec 20, 2024 • edited Loading

sjib commented Dec 20, 2024 • edited Loading

sjib commented Dec 20, 2024 • edited Loading

sjib commented Dec 20, 2024

sjib commented Dec 20, 2024

sjib commented Dec 11, 2024 •

edited

Loading

sjib commented Dec 20, 2024 •

edited

Loading

sjib commented Dec 20, 2024 •

edited

Loading

sjib commented Dec 20, 2024 •

edited

Loading