New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib): spawn vehicle property setting when warping #502

Merged

Manason merged 1 commit into main from fix-spawn-vehicle-warp

Jul 1, 2024

Contributor

Manason commented Jul 1, 2024

Fixes #501

Tested
Re-ordered operations so that first the vehicle bucket is set, then the player is warped, and then we wait for the vehicle to have an owner (warp is set it wait for the warping player to become the owner) and then the properties are set.
Ensures that properties are set, or else deletes the vehicle and throws an error.


          fix(lib): spawn vehicle property setting when warping

69c24ba

solareon approved these changes

View reviewed changes

Contributor

solareon left a comment

Makes sense, the order of operations between warp/prop set wasn't really discussed and this from a flow/onesync pov makes more sense.

modules/lib.lua Show resolved Hide resolved

solareon requested review from mafewtm and D4isDAVID

July 1, 2024 07:35

ghost approved these changes

View reviewed changes

Manason merged commit f55b653 into main

4 checks passed

Manason deleted the fix-spawn-vehicle-warp branch

July 1, 2024 14:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet