Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update events.lua #659

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Update events.lua #659

merged 1 commit into from
Jan 14, 2025

Conversation

SKITTLE6969
Copy link
Contributor

This change intend to stop the player count from going above the set amount in places like rich presence

Description

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

This change intend to stop the player count from going above the set amount in places like rich presence
Copy link
Contributor

@solareon solareon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume there is a minimum citizenfx version that this got added in? Also is there anywhere else that we modify this state?

@SKITTLE6969
Copy link
Contributor Author

SKITTLE6969 commented Jan 11, 2025

I presume there is a minimum citizenfx version that this got added in? Also is there anywhere else that we modify this state?

I've been having this on my qbox version since last Feb so I'm pretty sure citizenfx version won't cause any issues with anything after that before that I haven't tested.
So far this is the only instance I've seen this change required but will do a thorough search tomorrow and do the needful

@mafewtm mafewtm merged commit 85be28b into Qbox-project:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants