Add export to allow external scripts to get killer data

[JHansen2000]

Description

Add export to allow external scripts to get killer data

Checklist

• I have personally loaded this code into an updated Qbox project and checked all of its functionality.
• My pull request fits the contribution guidelines & code conventions.

[JHansen2000]

Sorry for the messy commits, I had some old code I was playing around with that was fixed by someone else's changes and I forgot to remove that old code prior to opening this PR.

[Manason]

Would this be better as an event instead?

[mafewtm]

What is the usecase for this as well?

[JHansen2000]

This is helpful for developers to be able to retrieve the killer's data for other scripts (i.e. a deathscreen that displays killer name and how they killed you). Without this export, external scripts must listen to the native CEventNetworkEntityDamage and parse it on their own, which is very inefficient since Qbox is doing this already.

I think this is better as an export, rather than an event, but am definitely open to discussion if you think an event would be better. What is the benefit of using an event over an export for this?

[Manason]

This is helpful for developers to be able to retrieve the killer's data for other scripts (i.e. a deathscreen that displays killer name and how they killed you). Without this export, external scripts must listen to the native CEventNetworkEntityDamage and parse it on their own, which is very inefficient since Qbox is doing this already.

I think this is better as an export, rather than an event, but am definitely open to discussion if you think an event would be better. What is the benefit of using an event over an export for this?

How would this be used? The event makes sense to me so that other scripts can listen for an onDeath event if they care to take action when the player dies. Otherwise, they will have to call the export in a loop to continuously check.

[JHansen2000]

This is helpful for developers to be able to retrieve the killer's data for other scripts (i.e. a deathscreen that displays killer name and how they killed you). Without this export, external scripts must listen to the native CEventNetworkEntityDamage and parse it on their own, which is very inefficient since Qbox is doing this already.

I think this is better as an export, rather than an event, but am definitely open to discussion if you think an event would be better. What is the benefit of using an event over an export for this?

How would this be used? The event makes sense to me so that other scripts can listen for an onDeath event if they care to take action when the player dies. Otherwise, they will have to call the export in a loop to continuously check.

I see where you're coming from. My scripts listen for changes to the client state bag instead of an event, so I only call the export when the state changes. I think this is good practice, but let me know if you disagree.

[Manason]

This is helpful for developers to be able to retrieve the killer's data for other scripts (i.e. a deathscreen that displays killer name and how they killed you). Without this export, external scripts must listen to the native CEventNetworkEntityDamage and parse it on their own, which is very inefficient since Qbox is doing this already.

I think this is better as an export, rather than an event, but am definitely open to discussion if you think an event would be better. What is the benefit of using an event over an export for this?

How would this be used? The event makes sense to me so that other scripts can listen for an onDeath event if they care to take action when the player dies. Otherwise, they will have to call the export in a loop to continuously check.

I see where you're coming from. My scripts listen for changes to the client state bag instead of an event, so I only call the export when the state changes. I think this is good practice, but let me know if you disagree.

Wouldn't it be more streamlined to have a named event with additional data (such as the killer data) rather than state bag listener + export?

[JHansen2000]

It would be more streamlined. I will update this tonight

[JHansen2000]

Sorry for the delay, this has been added simply as an event trigger. I do think this (and other events/exports) should be added to documentation somewhere but did not want to modify the README without approval.

[JHansen2000]

I passed the data as props to both OnDeath and StartLastStand and from there into the associated client & server events. It's all optional but is definitely very helpful. Hope that looks okay and this wasn't too much of a headache for you!