Refactor Gemini simulator tasks around backend objects#790
Draft
Krastanov-agent wants to merge 6 commits into
Draft
Refactor Gemini simulator tasks around backend objects#790Krastanov-agent wants to merge 6 commits into
Krastanov-agent wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for #789.
cc @Krastanov
Summary
task()into simulator constructorsrun()through backend sampling with consistent signaturesGeminiPhysicalSimulatorwhile keepingPhysicalSimulatoras a compatibility aliasBreaking changes
GeminiLogicalSimulator.task()now takes only the application kernel;m2detsandm2obsare simulator constructor argumentstask()now takes only the physical kernel; placement and annotation config are simulator constructor argumentsGeminiLogicalSimulator(backend="clifft", seed=...)is replaced byGeminiLogicalSimulator(backend=CliffTSimulatorBackend(seed=...))Verification
uv sync --locked --dev --all-extras --index-strategy=unsafe-best-matchuv run --locked pytest python/tests/ -q-> 1520 passed, 9 skippeduv run --locked ruff check ...on touched filesuv run --locked black --check --target-version py312 ...on touched filesuv run --locked pyright python/bloqade/gemini/device python/bloqade/gemini/decoding/experiments.pyNotes
tsim_circuit, samplers) remain available for Tsim-compatible backends because decoding utilities still use them.