Minor fixes

QuantConnect · Apr 11, 2024 · cd17661 · cd17661
1 parent b8a979b
commit cd17661
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 22 deletions.
diff --git a/Algorithm.Python/UniverseSelectedRegressionAlgorithm.py b/Algorithm.Python/UniverseSelectedRegressionAlgorithm.py
@@ -24,7 +24,7 @@ def Initialize(self):
 
         self.UniverseSettings.Resolution = Resolution.Daily
 
-        self.universe = self.AddUniverse(self.SelectionFunction)
+        self._universe = self.AddUniverse(self.SelectionFunction)
         self.selectionCount = 0
 
     def SelectionFunction(self, fundamentals):
@@ -37,13 +37,13 @@ def SelectionFunction(self, fundamentals):
         return [ x.Symbol for x in sortedByDollarVolume[:self.selectionCount] ]
 
     def OnData(self, data):
-        if Symbol.Create("TSLA", SecurityType.Equity, Market.USA) in self.universe.Selected:
+        if Symbol.Create("TSLA", SecurityType.Equity, Market.USA) in self._universe.Selected:
             raise ValueError(f"TSLA shouldn't of been selected")
 
-        self.Buy(next(iter(self.universe.Selected)), 1)
+        self.Buy(next(iter(self._universe.Selected)), 1)
 
     def OnEndOfAlgorithm(self):
         if self.selectionCount != 3:
             raise ValueError(f"Unexpected selection count {self.selectionCount}")
-        if self.universe.Selected.Count != 3 or self.universe.Selected.Count == self.universe.Members.Count:
-            raise ValueError(f"Unexpected universe selected count {self.universe.Selected.Count}")
+        if self._universe.Selected.Count != 3 or self._universe.Selected.Count == self._universe.Members.Count:
+            raise ValueError(f"Unexpected universe selected count {self._universe.Selected.Count}")
diff --git a/Algorithm/UniverseDefinitions.cs b/Algorithm/UniverseDefinitions.cs
@@ -38,14 +38,8 @@ public class UniverseDefinitions
         /// <summary>
         /// Specifies that universe selection should not make changes on this iteration
         /// </summary>
-        [StubsIgnore]
         public Universe.UnchangedUniverse Unchanged => Universe.Unchanged;
 
-        /// <summary>
-        /// Alias for <see cref="Unchanged"/>
-        /// </summary>
-        public Universe.UnchangedUniverse UNCHANGED => Unchanged;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="UniverseDefinitions"/> class
         /// </summary>

diff --git a/Common/Data/UniverseSelection/Universe.cs b/Common/Data/UniverseSelection/Universe.cs
@@ -38,14 +38,8 @@ public abstract class Universe : IDisposable
         /// <summary>
         /// Gets a value indicating that no change to the universe should be made
         /// </summary>
-        [StubsIgnore]
         public static readonly UnchangedUniverse Unchanged = UnchangedUniverse.Instance;
 
-        /// <summary>
-        /// Alias for <see cref="Unchanged"/>
-        /// </summary>
-        public static readonly UnchangedUniverse UNCHANGED = Unchanged;
-
         private HashSet<Symbol> _previousSelections;
 
         /// <summary>

diff --git a/Tests/Algorithm/AlgorithmDownloadTests.cs b/Tests/Algorithm/AlgorithmDownloadTests.cs
@@ -62,15 +62,15 @@ public void Download_With_Python_Parameter_Successfully()
             var byteKey = Encoding.ASCII.GetBytes($"UserName:Password");
             var value = $"Basic ({Convert.ToBase64String(byteKey)})";
 
-            var headers = new PyDict();
             using (Py.GIL())
             {
+                var headers = new PyDict();
                 headers.SetItem("Authorization".ToPython(), value.ToPython());
-            }
 
-            var content = string.Empty;
-            Assert.DoesNotThrow(() => content = algo.Download("https://www.quantconnect.com/", headers));
-            Assert.IsNotEmpty(content);
+                var content = string.Empty;
+                Assert.DoesNotThrow(() => content = algo.Download("https://www.quantconnect.com/", headers));
+                Assert.IsNotEmpty(content);
+            }
         }
     }
 }