-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future Stop Market Order in Out Market Hours #7678
Future Stop Market Order in Out Market Hours #7678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Leaving some minor comments.
Algorithm.CSharp/FutureStopMarketOrderOnExtendedHoursRegressionAlgorithm.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Minor comments
Algorithm.Python/FutureStopMarketOrderOnExtendedHoursRegressionAlgorithm.py
Outdated
Show resolved
Hide resolved
Algorithm.CSharp/FutureStopMarketOrderOnExtendedHoursRegressionAlgorithm.cs
Outdated
Show resolved
Hide resolved
fix: styling format in PY
feature: validate that all stop orders was completed in algos
…Data fix:style: missed braces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Looks good 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ty👍 , minor comments shared through slack
remove: extra login in algo
remove: extra log in PY version of algo
Description
Add opportunity for Future securities to create
StopMarketOrder
in out market hour.Related Issue
Closes #6948
Motivation and Context
I will want to help users to create new algorithms with new option of Future security.
Requires Documentation Change
N/A
How Has This Been Tested?
.cs
|.py
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>