-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Binance currency pairs #7693
Update Binance currency pairs #7693
Conversation
We also have a request for GBP-quoted crypto pairs. It's out of the scope of the issue that led to this pull request, but we could add a commit to address it too. |
Actually yes, it's not a complete list of the pairs that are absent. If it's okay to go out of scope here, I could add a broader range of crypto pairs (i.e. all that are absent at the moment) |
Hey @starteleport ! Thank you for the contribution, |
7af69c1
to
34073f8
Compare
@Martin-Molinero done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Looks good. Just one comment: why the changes in the Kraken symbols?
Thank you @starteleport! Almost there, please revert the kraken SPDB changes like JA noted 👍. There seems to be a few unit tests failing in the PR, possibly related to that change |
34073f8
to
c8625c5
Compare
c8625c5
to
de9200a
Compare
Ah, sorry for Kraken bits, they were supposed to be rolled back. |
Also, I'm looking into the failing tests now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
ab143c3
to
e113564
Compare
@Martin-Molinero, could you review again, please? I've fixed a typo in a symbol name. |
That's kind of strange. I have I'm not sure about the reasons, because this seems unrelated. Any ideas? If not, I'll look into that a bit later. |
It looks like the API used during the test is failing:
Given that there had been quite a few test runs of this test recently, and the throttling inside |
Hey @starteleport! Thank you 🚢 |
Description
This adds missing Binance symbols to the symbol database.
Related Issue
Closes #7692
Motivation and Context
Some existing Binance trading pairs were absent in the symbol database.
Requires Documentation Change
No
How Has This Been Tested?
This is the metadata change only, so I suppose there is no need to run tests.
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>