Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option Delta Indicator #7704

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Option Delta Indicator #7704

merged 8 commits into from
Jan 29, 2024

Conversation

LouisSzeto
Copy link
Collaborator

Description

Add Option Delta indicator for Option securities

Related Issue

closes #7667
related to #7611

Motivation and Context

Requested feature

Requires Documentation Change

Add section in Writing Algorithm - Indicator

How Has This Been Tested?

Added unit tests and compared to IB & QuantLib data

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Leaving minor comments 👍

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 shared minor comments in slack

@Martin-Molinero Martin-Molinero merged commit 3a10afe into QuantConnect:master Jan 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option Delta Indicator
2 participants