Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add early closes for U.S. Indices in MHDB #7707

Conversation

Marinovsky
Copy link
Collaborator

Description

This PR adds early closes to the Indices entries in the MHDB, namely: VIX, NDX and SPX. After searching for this information in CBOE and Nasdaq webpages, it was found a common pattern between the early closes of U.S. Equities and the ones of the aforementioned indices; they were the same for both entries (they differed in the early close time, but the days were the same). Below, it can be found the sources of this information.

NASDAQ

CBOE

Related Issue

Closes #7599

Motivation and Context

With this change, users will have accurate information regarding the market hours for U.S. indices on holidays

Requires Documentation Change

N/A

How Has This Been Tested?

It was created a unit test asserting the indices options relied on their underlyings to get the early closes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Minor comment shared

@Martin-Molinero Martin-Molinero merged commit 580a043 into QuantConnect:master Jan 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Early and Late Close for Index and Index Options
2 participants