Merge early closes and late opens properly in MHDB #7712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When late opens or early close times are different in a more specific entry, they following error is shown without exiting the algorithm:
A more specific entry (like
Indices-usa-VIX
) might contain some of the same early close/late open dates as the common entry (Indices-usa-[*]
) but with different times. These changes make sure this is handle and the more specific ones take precedence.For instance, in the following market hours database JSON string:
The resulting
MarketHoursDatabase
instance would have the following early closes and late opens, where the times for the dates 11/25/2017 and 11/25/2018 would take the times as they appear in the specific entryEquity-usa-GOOG
:Related Issue
N/A
Motivation and Context
N/A
Requires Documentation Change
N/A
How Has This Been Tested?
Unit tests
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>