Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve failing unit test LiveOptionChainProviderReturnsFutureOptionData #7735

Conversation

Marinovsky
Copy link
Collaborator

Description

It seems that the unit test was failing because after making too many requests to the CME Group API, the API thought the requests were for web scraping activities. After adding the appropriate headers in the requests, the unit test passed again. See https://www.browserbear.com/blog/web-scraping-without-getting-blocked-5-common-reasons-youre-blocked-and-how-to-avoid-them-2/#too-many-requests-from-your-ip-address

Related Issue

Closes #7688

Motivation and Context

With this change, the unit test LiveOptionChainProviderReturnsFutureOptionData will pass again

Requires Documentation Change

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌

@Martin-Molinero Martin-Molinero merged commit 6f29130 into QuantConnect:master Jan 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live Future Option Chain Provider Failing
2 participants