Disable directory rename #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afshin
reviewed
Jan 28, 2025
| @@ -511,6 +513,29 @@ namespace Private { | |||
| '.jp-SidePanel .jp-DirListing-content .jp-DirListing-item[data-isDir]', | |||
| rank: 10 | |||
| }); | |||
|
|
|||
| app.commands.addCommand(CommandIDs.rename, { | |||
| execute: args => { | |||
There was a problem hiding this comment.
I guess we don't use args and we rely on the widget to do all the work? Sort of funny to have a rename command that doesn't actually do the renaming.
There was a problem hiding this comment.
Oh yeah, we don't use args, that's interesting. The command was modeled after the one in jupyterlab: https://github.com/jupyterlab/jupyterlab/blob/68075b17a11258481f5aba68f473788aeaa88650/packages/filebrowser-extension/src/index.ts#L1191-L1207
|
Thank you for the review @afshin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable directory rename as
S3has rename disabled for folders and no straight-forward functionality to do so transparently.The rename logic is still present and entails copying each individual object inside the original folder and then deleting it, but it will not be accessed for directory renames.