Skip to content

Conversation

@wmertens
Copy link
Member

@wmertens wmertens commented Jan 7, 2026

includes doubleclick fix

@wmertens wmertens requested review from a team as code owners January 7, 2026 13:48
@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

⚠️ No Changeset found

Latest commit: 183d40b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 183d40b

@wmertens
Copy link
Member Author

the reason the tests fail is because vite-imagetools emits two different sets of images in client and ssr builds (different hashes). Still investigating.

Maybe #7754 is the same issue

@wmertens
Copy link
Member Author

created JonasKruckenberg/imagetools#852 for the imagetools issue

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 12, 2026

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8225
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8225
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8225
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8225

commit: 183d40b

@wmertens wmertens merged commit 1d1c4d0 into build/v2 Jan 12, 2026
20 checks passed
@wmertens wmertens deleted the v2-fixes branch January 12, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants