Skip to content

Conversation

@maiieul
Copy link
Member

@maiieul maiieul commented Jan 10, 2026

What is it?

  • Bug

Description

Because of #8097, the routeLocation and routeStateInternal url origins could get out of sync in case the envUrl was setup dynamically. This should fix the issue and hopefully not be problematic for anyone.

I'll add a test for it once we have vitest browser mode for component & hooks testing.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner January 10, 2026 19:44
@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2026

🦋 Changeset detected

Latest commit: 6abc9fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch
@builder.io/qwik-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gioboa
gioboa previously approved these changes Jan 10, 2026
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the changeset file?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 10, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@8234
npm i https://pkg.pr.new/@builder.io/qwik-city@8234
npm i https://pkg.pr.new/eslint-plugin-qwik@8234
npm i https://pkg.pr.new/create-qwik@8234

commit: 6abc9fc

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 4c2e58d

@maiieul
Copy link
Member Author

maiieul commented Jan 10, 2026

thanks for the reminder @gioboa 😄

@maiieul maiieul marked this pull request as draft January 10, 2026 20:38
@maiieul
Copy link
Member Author

maiieul commented Jan 10, 2026

Keeping as draft for now as I'd like to test it out on a production app.

@maiieul maiieul self-assigned this Jan 13, 2026
@maiieul maiieul moved this from Backlog to Done in Qwik Development Jan 13, 2026
@maiieul maiieul marked this pull request as ready for review January 13, 2026 20:11
@shairez shairez moved this from Done to Waiting For Review in Qwik Development Jan 13, 2026
@shairez shairez moved this from Waiting For Review to Done in Qwik Development Jan 13, 2026
@shairez shairez merged commit 6f6756b into QwikDev:main Jan 13, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants