-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(qwik-city): spa routeInternal and routeLocation url mismatch #8234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(qwik-city): spa routeInternal and routeLocation url mismatch #8234
Conversation
🦋 Changeset detectedLatest commit: 6abc9fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the changeset file?
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
thanks for the reminder @gioboa 😄 |
|
Keeping as draft for now as I'd like to test it out on a production app. |
What is it?
Description
Because of #8097, the routeLocation and routeStateInternal url origins could get out of sync in case the envUrl was setup dynamically. This should fix the issue and hopefully not be problematic for anyone.
I'll add a test for it once we have vitest browser mode for component & hooks testing.
Checklist
pnpm change