Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in missing arg for arg_match in list_field_domains #235

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

elipousson
Copy link
Contributor

I used encode_field_values() with the field argument set this evening for the first time and caught what is (in retrospect) an obvious error in the arg_match call used by list_field_domains() to validate the input.

Changes

Fill in field as the arg parameter of rlang::arg_match within list_field_domains().

@JosiahParry JosiahParry merged commit 3893210 into R-ArcGIS:main Feb 2, 2025
6 checks passed
@JosiahParry
Copy link
Collaborator

We should add a test for this:

library(arcgislayers)

flayer <- arc_open("https://services1.arcgis.com/99lidPhWCzftIe9K/ArcGIS/rest/services/UtahRoads/FeatureServer/0")

res <- arc_select(flayer, n_max = 100)

encode_field_values(res, flayer, field = "CARTOCODE")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants