Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of missing values for encoded fields #238

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve handling of missing values for encoded fields #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64ce411
Improve handling of missing values for encoded fields
elipousson Feb 3, 2025
90a7daf
Add test w/ explicit field argument
elipousson Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion R/arc-read.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,9 @@ encode_field_values <- function(
# Replace column values by default
if (codes == "replace") {
for (col in names(values)) {
.data[[col]] <- values[[col]][.data[[col]]]
replace_val <- values[[col]]
miss_val <- is.na(.data[[col]])
.data[[col]][!miss_val] <- replace_val[.data[[col]][!miss_val]]
}

return(.data)
Expand Down
17 changes: 17 additions & 0 deletions tests/testthat/test-encode-field-values.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,20 @@ test_that("encode_field_values() encodes field values", {

expect_true(all(encoded_vals %in% domain_vals))
})

test_that("encode_field_values() encodes field values when field is set", {
skip_on_cran()
flayer <- arc_open(
"https://services1.arcgis.com/99lidPhWCzftIe9K/ArcGIS/rest/services/UtahRoads/FeatureServer/0"
)

res <- arc_select(layer, n_max = 100)

encoded <- encode_field_values(res, flayer, field = "CARTOCODE")

# fetch domains and known values
domains <- list_field_domains(layer, field = "CARTOCODE")
domain_vals <- domains[[c("CARTOCODE", "codedValues", "name")]]

expect_true(all(encoded[["CARTOCODE"]] %in% domain_vals))
})
Loading