Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateScriptInstance #692

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

EladNLG
Copy link
Member

@EladNLG EladNLG commented Apr 25, 2024

Adds a function that converts entities to SQObjects to the SquirrelManagers.

@EladNLG EladNLG mentioned this pull request Apr 25, 2024
2 tasks
Copy link
Member

@catornot catornot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, checked the offsets in ghidra 👍
didn't test in game.

@catornot catornot added the needs testing Changes from the PR still need to be tested label Apr 25, 2024
@EladNLG
Copy link
Member Author

EladNLG commented May 6, 2024

Ok, genuinely, how can this be even tested?

@GeckoEidechse
Copy link
Member

Ok, genuinely, how can this be even tested?

Usually the approach is to have a small PoC script mod that highlights the change. I don't understand enough atm to tell you whether that would make sense in this case ^^"

@EladNLG
Copy link
Member Author

EladNLG commented May 6, 2024

Ok, genuinely, how can this be even tested?

Usually the approach is to have a small PoC script mod that highlights the change. I don't understand enough atm to tell you whether that would make sense in this case ^^"

Unfortunately, no known part of the codebase (outside of #691) uses pushobject/createscriptinstance. My guess is that #691 will test this by proxy?

@catornot
Copy link
Member

catornot commented May 6, 2024

I did test the server offsets in a plugin :p

@GeckoEidechse
Copy link
Member

Maybe we just merge without further testing ig?

@catornot
Copy link
Member

Maybe we just merge without further testing ig?

Yeah, just merge it.

@GeckoEidechse
Copy link
Member

Aight consider it merged. I might just gonna put a few more fixes in front to reduce the amount of cherry-picking I have to do ^^

@GeckoEidechse GeckoEidechse added the READY TO MERGE This mergeable right now label Jul 10, 2024
@GeckoEidechse GeckoEidechse merged commit 51991cc into R2Northstar:main Jul 29, 2024
4 checks passed
@catornot
Copy link
Member

Wow this got finally merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Changes from the PR still need to be tested READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants