-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement mod versioning #1051
base: main
Are you sure you want to change the base?
Conversation
@GeckoEidechse what should happen when flightcore can't load |
I'd say rebuild in v0 for now but have a feature flag or simple conditional check to tell it to rebuild in v1 instead. That way we can just "flip the switch" when we release the corresponding update in Northstar. |
Clippy CI errors are from update in Rust toolchain and will be fixed by #1053 |
… into feat/mod-versioning
Implementation of R2Northstar/NorthstarLauncher#828 new manifest format, going from:
to:
If the current version of the manifest cannot be defined automatically,
NORTHSTAR_MODS_MANIFEST_VERSION
default value will be used instead.(This is not a breaking change, as the current manifest format support is preserved.)
TODOs
set_mod_enabled_status
with mods we don't know the version to enable/disable (e.g. core mods/mod settings)rebuild_enabled_mods_json
Testing
With this contribution, Flightcore supports both manifest versions dynamically, which means you can switch between profiles using different versions with no issues.
To test this, I configured a
R2Northstar
profile with current manifest format, and aR2Development
profile with new manifest format:mod-versioning-support.webm
v0 (current format) manifest: enabledmods.json
v1 (new format) manifest: enabledmods.json