Skip to content

Commit

Permalink
Suggested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
RyanR712 committed Dec 5, 2023
1 parent 50165f1 commit ae245be
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 43 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/runTests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ jobs:
run: npm ci

- name: Run all vitest tests
run: npm run aegtest
run: npx vitest
6 changes: 3 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ peircemyheart-*
docs
public/docs
electron-build
/test-results/
/playwright-report/
/playwright/.cache/
test-results/
playwright-report/
playwright/.cache/
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ We also use it to invoke all core development tools via `npm run`.
2. [**Vite**](https://vitejs.dev/) : Vite is an asset bundler and build system for large web projects with
many types of resources such as typescript. Additionally, it provides excellent debugging features.
We use it as a build system for Typescript, Asset Compressor, and Live Debugger.
* **Playwright** : a testing framework compatible with Vite with support for TypeScript. Very similar to Vitest but more for the UI side of things.
* **Playwright** : a testing framework compatible with Vite with support for TypeScript.
* **Vitest** : a testing framework native to Vite with support for TypeScript. It allows for github workflow compatibility and running numerous tests with one command.

3. [**gts**](https://github.com/google/gts) : gts (Google TypeScript Style) is a set of style guidelines and tools for typescript
Expand Down
37 changes: 0 additions & 37 deletions playwright.config.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
import {defineConfig, devices} from "@playwright/test";

/**
* Read environment variables from file.
* https://github.com/motdotla/dotenv
*/
// require('dotenv').config();

/**
* See https://playwright.dev/docs/test-configuration.
*/
Expand Down Expand Up @@ -38,36 +31,6 @@ export default defineConfig({
name: "chromium",
use: {...devices["Desktop Chrome"]},
},
/*
{
name: "firefox",
use: {...devices["Desktop Firefox"]},
},
{
name: "webkit",
use: {...devices["Desktop Safari"]},
},
*/
/* Test against mobile viewports. */
// {
// name: 'Mobile Chrome',
// use: { ...devices['Pixel 5'] },
// },
// {
// name: 'Mobile Safari',
// use: { ...devices['iPhone 12'] },
// },

/* Test against branded browsers. */
// {
// name: 'Microsoft Edge',
// use: { ...devices['Desktop Edge'], channel: 'msedge' },
// },
// {
// name: 'Google Chrome',
// use: { ...devices['Desktop Chrome'], channel: 'chrome' },
// },
],

//Run your local dev server before starting the tests
Expand Down
1 change: 0 additions & 1 deletion tests/UI/atom.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ test.beforeAll("Reading expected strings in from .json files...", async () => {
});

fs.readFile(__dirname + "/expectedTrees/loneAtom.json", "utf8", (err: Error, data: string) => {
//loneAtomString = data.substring(data.lastIndexOf("A"), data.lastIndexOf("},"));
loneAtomString = data;
});

Expand Down

0 comments on commit ae245be

Please sign in to comment.