Playwright integration! #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: .gitignore - changes made by Playwright install package-lock.json, package.json - changes made by Playwright install README.md - updated commands, a couple missing directory explanations runTests.yml - renamed the test calls to aegtest settings.json - added some words to the spellcheck ignored Additions: playwright.config.js - added by Playwright install, changed by me to adhere to our lint playwright.yml - added by Playwright install, changed by me to reference master, not main, and to timeout only after 5 minutes example.spec.ts - added by Playwright install. LEARN FROM THIS! DO NOT LEAVE THIS IN THE FINAL PRODUCT!!!
RyanR712
added
Enhancement
Closed
6 tasks
vite.config.js - changed vitest run config to search in tests/AEGTree to reflect E2E and "backend" test split All test.ts files - moved to tests/AEGTree and updated import statements
…47-Playwright-integration-and-tests
about.html - added title attributes for use in aboutAeg.spec.ts
index.ts - added global field for tree playwright.config.js - removed external html log because it hogged the terminal until I restarted the thing. annoying! not fun! now prints entirely in console Test still flaky
playwright.config.js - Tests now only run on Chromium playwright.yml - removed job for uploading test result artifact atom.spec.ts, loneAtom.json - seeing how these compare to what the robots expect
James-Oswald
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup for Dawn and Anusha