Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deiteration working #258

Merged
merged 4 commits into from
Nov 26, 2023
Merged

Deiteration working #258

merged 4 commits into from
Nov 26, 2023

Conversation

DawnTheWitch
Copy link
Collaborator

No description provided.

@DawnTheWitch DawnTheWitch self-assigned this Nov 26, 2023
@DawnTheWitch DawnTheWitch linked an issue Nov 26, 2023 that may be closed by this pull request
Deiteration (Easier) #257
Closed
@DawnTheWitch DawnTheWitch changed the title Deiteration Working, but still needs work Deiteration working, but still needs work Nov 26, 2023
@DawnTheWitch DawnTheWitch changed the title Deiteration working, but still needs work Deiteration working Nov 26, 2023
@DawnTheWitch DawnTheWitch marked this pull request as ready for review November 26, 2023 16:36
RyanR712
RyanR712 approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@RyanR712 RyanR712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fine and style looks consistent. Only issues are grammar/punctuation and that can go under #154

James-Oswald
James-Oswald approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@James-Oswald James-Oswald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some basic tests, seems to work.

src/ProofTools/DeiterationTool.ts Outdated Show resolved Hide resolved
@DawnTheWitch DawnTheWitch merged commit 54a0967 into master Nov 26, 2023
8 checks passed
@DawnTheWitch DawnTheWitch deleted the 257-deiteration-easier branch November 26, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James-Oswald James-Oswald James-Oswald approved these changes

@RyanR712 RyanR712 RyanR712 approved these changes

Assignees

@DawnTheWitch DawnTheWitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deiteration (Easier)
3 participants
@DawnTheWitch @James-Oswald @RyanR712