Adding importdescriptors for Descriptor-Based Wallets

[sandipndev]

This PR adds the following features:

1. importdescriptors RPC command
2. Bech32m address support
3. Updated createwallet to add in descriptors parameter

The integration_test/run.sh script was updated to support the latest versioning of Bitcoin Core.

I figure this would be very useful for anyone creating descriptor based wallets, especially with Taproot coming in!

[sandipndev]

Hi, I am facing a challenge in this PR.

There seems to be a difference between the results coming from bitcoin-cli and bitcoin json-rpc when the same payload is being passed to both of them.

Reproduction:

1. I am using bitcoind v22.0rc2, which is unreleased and compiled from source with wallet support.
2. I commented out the kill on this line here and ran ./run.sh.
3. With the kill now gone, bitcoind is running and listening to RPC on port 12349.
4. Paste the payload, it contains the descriptors:

PAYLOAD="[{\"active\":true,\"desc\":\"wpkh(tprv8ZgxMBicQKsPeTNzU5evMToRhHA9h3UCxbpzrzjUWUd6TQktkhmY82dQx5f6QaFpSWMzZxKz16xQFGeW7ykPjYuTetU6ep9aFTpAt7jKhPU/44'/0'/0'/0/*)#w2lyh4jx\",\"internal\":false,\"range\":[0,100],\"timestamp\":\"now\"},{\"active\":true,\"desc\":\"wpkh(tprv8ZgxMBicQKsPeTNzU5evMToRhHA9h3UCxbpzrzjUWUd6TQktkhmY82dQx5f6QaFpSWMzZxKz16xQFGeW7ykPjYuTetU6ep9aFTpAt7jKhPU/44'/0'/0'/0/*)#w2lyh4jx\",\"internal\":true,\"range\":[0,999],\"timestamp\":\"now\"}]"

4. Run bitcoin-cli command: (It should pass with success messages)

bitcoin-cli -regtest -datadir=/tmp/rust_bitcoincore_rpc_test/2 --rpcport="12349" importdescriptors $PAYLOAD

5. Restart ./run.sh
6. Now, we are going to pass the same payload via json-rpc using curl. Run the curl command:

curl --user $(cat /tmp/rust_bitcoincore_rpc_test/2/regtest/.cookie) --data-binary "{\"jsonrpc\": \"1.0\", \"id\": \"test\", \"method\": \"importdescriptors\", \"params\": $PAYLOAD}" -H 'content-type: text/plain;' http://localhost:12349/ | jq

It returns an error code -1 with the importdescriptors help message.
This is what is confusing to me, why does the same payload produce different results?

This is also the reason the test corresponding to this PR gets failed. Can anyone help me out on this?

[notmandatory]

I was able to get the request passed and successful via the rpc-client test. I had to make the request with a single argument which contains the a json array value containing the json descriptor objects. I'm now getting an error parsing the success result, but once that's fixed I can review it with you.

[sandipndev]

Thanks to @notmandatory, we resolved this issue. It's ready to review now!

[notmandatory]

tACK 4c93f8b

[RCasatta]

from a quick look, the PR is good but I am not yet sure I am going to maintain this repo unless there are no other options.

This is a topic we will discuss in the next bdk meeting

[notmandatory]

@sandipndev can you also make a version of this PR for the https://github.com/rust-bitcoin/rust-bitcoincore-rpc?

@RCasatta we discussed the issue a little in our last bdk team chat and I think the consensus was to submit PRs to both your fork and the upstream until upstream gets caught up.

[RCasatta]

ack a3df1c2

[notmandatory]

post merge ACK a3df1c2

good job @sandipndev! 🎉 don't forget to also update rust-bitcoin#199 to match this one