Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/console basic #82

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Feature/console basic #82

wants to merge 8 commits into from

Conversation

KirmesBude
Copy link
Contributor

@KirmesBude KirmesBude commented Aug 5, 2019

Basics for a in-game console.
I removed the tries for now. I wont have a lot of time until september so I want to get the basics in at least - could be useful for implementing other features.
See feature/console for another approach.

Not sure I am happy with Console calling into UIConsole, because it means Console will need to be added last. But looking at "toggle frame"/etc. maybe it needs to anyways.
Leads to way cleaner command declarations for one.

UIConsole seems to consistently not render the scrollarea when loaded into WORLD(instead of OLDMINE) or after clearing it. Not sure why.

src/CMakeLists.txt Outdated Show resolved Hide resolved
src/RTTI/RTTI_Console.hpp Outdated Show resolved Hide resolved
src/RTTI/RTTI_UIConsole.hpp Outdated Show resolved Hide resolved
Allow extra trailing arguments for now
changed Spawnmass to SpawnMass
"Fix" help command for multi-word commands
@mworchel
Copy link
Contributor

mworchel commented Aug 8, 2019

Didn't look at all the details yet but is there a particular reason why the Console should be a bs::Component? It is not serialized and not updated every frame. Why not make it a plain class that is not even bs::IReflectable?

@KirmesBude
Copy link
Contributor Author

Didn't look at all the details yet but is there a particular reason why the Console should be a bs::Component? It is not serialized and not updated every frame. Why not make it a plain class that is not even bs::IReflectable?

No reason at all.
I initially thought there might be some merit in serializing the history or datastructures for auto-completion, so I started with a component.

@ataulien
Copy link
Contributor

Finally got to test this! It is sooo cool to just type insert WOLF and have a wolf run around the oldmine! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants