fixed a bug in __PHYSFS_platformCalcUserDir() #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! The bug has indeed already been found, and is fixed upstream. We should migrate to using this automatic mirror I have setup here wherever we use PhysFS as a submodule |
|
Hi! So this is an outdated repository? I checked the history of "physfs_platform_windows.c" in the mirror repository and you even narrowed it down to a specific Windows 10 build, that's neat. Well then, nevermind my pull request. :) |
|
I have not personally fixed the bug, this is just a mirror of the official Mercurial repo for PhysicsFS (https://hg.icculus.org/icculus/physfs/) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call of pGetDir() returned error code 87 (ERROR_INVALID_PARAMETER) and left psize set to 0. That's why the second call to pGetDir() always failed on my machine.
If NULL is passed to the first call, error code 122 (ERROR_INSUFFICIENT_BUFFER) is returned instead and a valid value is written into psize, making the second call successful.
I'm curious that this bug hasn't been found earlier. I'm running latest Windows 10 and maybe the WinAPI behaves somewhat different to previous versions?