Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetTag compatible with wasm target #202

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

theacdutra
Copy link
Member

Description

This PR intent fix Asset Tag initialization to wasm target compilation.

When we try issuing a new contract with wasm target, the builder crashes on AssetTag initialization. I changed std::time::SystemTime to chrono::Local.

CC @cryptoquick

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (729c652) 16.7% compared to head (e433086) 16.7%.

❗ Current head e433086 differs from pull request most recent head aeec368. Consider uploading reports for the commit aeec368 to get more accurate results

Files Patch % Lines
src/contract/fungible.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #202   +/-   ##
======================================
  Coverage    16.7%   16.7%           
======================================
  Files          32      32           
  Lines        3874    3874           
======================================
  Hits          646     646           
  Misses       3228    3228           
Flag Coverage Δ
rust 16.7% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK aeec368

@dr-orlovsky dr-orlovsky merged commit c51af67 into RGB-WG:master Jan 26, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants