Assignment interfaces for rgb20 #156
Conversation
add three interfaces of iimpl to IfacePair: global_name, assignment_name, transition_name in
new assignment interfaces for rgb20
src/interface/contract.rs
Outdated
| pub type InflationAllowanceAllocation = OutputAssignment<Amount>; | ||
| pub type UpdateRights = OutputAssignment<VoidState>; | ||
| pub type BurnEpoch = OutputAssignment<VoidState>; | ||
| pub type BurnRight = OutputAssignment<VoidState>; |
There was a problem hiding this comment.
I think we do not need these newtypes (and certainly not in the global namespace, since they are RGB20-specific).
Just use FungibleAllocation, and RightsAllocation instead in the code you have added. The rest looks good
There was a problem hiding this comment.
have changed the code, and thanks for the advice(fmt and clippy).
Another PR just published, you can review it.
There was a problem hiding this comment.
The other PR is merged, so can you pls update this PR with removing these type names - and I will merge it and proceed to the next ones
There was a problem hiding this comment.
@cymqqqq your PRs share the same commits, thus if you update one of them the other will have a diverging history. I suggest to split the commits into PRs (such that each one has one or two) - or just give the one PR with all commits. Otherwise the process will be quite complex
There was a problem hiding this comment.
I have updated this PR, and thanks, I will try my best to just give one PR later. :)
new assignment interfaces for rgb20