Complete deterministic builder #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoedberg
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Tested, it works so I'm approving this.
Just a small note: trying to use deterministic methods on a builder constructed with ContractBuilder::with returns the error to add owned state in deterministic way the builder has to be created using `*_det` constructor, which IMO makes the user think he should call ContractBuilder::with_det, but that doesn't exist and the correct way of constructing a deterministic builder is ContractBuilder::deterministic. So maybe we should rename the deterministic method to with_det or change the error message of deterministic methods.
|
Sure! Done in 0a392e7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #190 (comment)