Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm compilation #127

Closed
wants to merge 9 commits into from
Closed

Conversation

theacdutra
Copy link
Member

No description provided.

@theacdutra theacdutra force-pushed the fix/wasm-compilation branch from d3d639c to 9261a4a Compare February 9, 2024 02:11
@dr-orlovsky dr-orlovsky changed the base branch from v0.11 to master February 10, 2024 09:18
@dr-orlovsky
Copy link
Member

This will not pass CI and break a lot of compile variants. Since you did the PR agains v0.11 CI doesn't run; I changed it to be against the master branch. Let's see the errors.

Overall I do not understand why you need this since rgb crate is a command-line tool which should not be used from WASM. You have other lower-level libraries for that...

@dr-orlovsky
Copy link
Member

@crisdut and please can you do this just as a branch with a single last commit and not on top of other PR? They are unrelated.

@theacdutra
Copy link
Member Author

theacdutra commented Feb 10, 2024

This will not pass CI and break a lot of compile variants. Since you did the PR agains v0.11 CI doesn't run; I changed it to be against the master branch. Let's see the errors.

I had created this PR to demonstrate my suggestion for changes, as you had commented that you had not understood my suggestions in the thread. My idea was to merge into your branch, I didn't quite understand why you pointed to master, if #103 remains open.

Overall I do not understand why you need this since rgb crate is a command-line tool which should not be used from WASM. You have other lower-level libraries for that...

In fact, I left the CLI optional, precisely so as not to use it in WASM, since all PSBT and payment modules are contained in rgb_rt, to avoid I having to copy and paste the entire library into bitmask-core.

@dr-orlovsky
Copy link
Member

Now I get it: you need PSBT package and would like to compile for WASM.

I am asking to do just one commit against master since otherwise I can't get CI running and not sure that this compiles

@dr-orlovsky dr-orlovsky changed the base branch from master to v0.11 February 13, 2024 15:08
@dr-orlovsky
Copy link
Member

I think the right way of fixing this is this one: BP-WG/bp-wallet@9d1cf14

We have discussion on the same matter here: #128 (review)

This was referenced Feb 13, 2024
@theacdutra theacdutra closed this Feb 15, 2024
@theacdutra theacdutra deleted the fix/wasm-compilation branch February 15, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants