-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wasm compilation #127
Fix wasm compilation #127
Conversation
fix electrum Resolver
d3d639c
to
9261a4a
Compare
This will not pass CI and break a lot of compile variants. Since you did the PR agains v0.11 CI doesn't run; I changed it to be against the master branch. Let's see the errors. Overall I do not understand why you need this since |
@crisdut and please can you do this just as a branch with a single last commit and not on top of other PR? They are unrelated. |
I had created this PR to demonstrate my suggestion for changes, as you had commented that you had not understood my suggestions in the thread. My idea was to merge into your branch, I didn't quite understand why you pointed to master, if #103 remains open.
In fact, I left the CLI optional, precisely so as not to use it in WASM, since all PSBT and payment modules are contained in |
Now I get it: you need PSBT package and would like to compile for WASM. I am asking to do just one commit against |
I think the right way of fixing this is this one: BP-WG/bp-wallet@9d1cf14 We have discussion on the same matter here: #128 (review) |
No description provided.